spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4714][CORE]: Add checking info is null ...
Date Sat, 06 Dec 2014 19:48:30 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3574#discussion_r21418614
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -1010,9 +1010,9 @@ private[spark] class BlockManager(
           info.synchronized {
             // required ? As of now, this will be invoked only for blocks which are ready
             // But in case this changes in future, adding for consistency sake.
    -        if (!info.waitForReady()) {
    +        if (blockInfo.get(blockId).isEmpty || !info.waitForReady()) {
    --- End diff --
    
    It might be nice to split this into an `if` and `else if` case so that we can log specific
/ accurate error messages in each of the cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message