Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: zsxwing <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3241-spark@git.apache.org>
In-Reply-To: <git-pr-3241-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-4379][Core] Change Exception to
 SparkEx...
Content-Type: text/plain
Message-Id: <20141114020809.DDD2C93A781@tyr.zones.apache.org>
Date: Fri, 14 Nov 2014 02:08:09 +0000 (UTC)

Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/3241#issuecomment-63000329
  
    I'm sorry that I should have been clearer when I said the breaking change. I'm worried about the following   case:
    ```
      try {
        rdd.checkpoint()
      } catch {
        case e: SparkException => // do work A
        case e: Exception => do work B
      }
    ```
    It breaks such case. However, I think few people will write such code.
    
    Therefore, does Spark view such change as a breaking change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org