Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: marmbrus <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3139-spark@git.apache.org>
In-Reply-To: <git-pr-3139-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-4274] [SQL] Print informative
 message w...
Content-Type: text/plain
Message-Id: <20141107202031.C3B2499D3BF@tyr.zones.apache.org>
Date: Fri,  7 Nov 2014 20:20:31 +0000 (UTC)

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3139#discussion_r20034795
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala ---
    @@ -341,12 +341,21 @@ abstract class HiveComparisonTest
               val query = new TestHive.HiveQLQueryExecution(queryString)
               try { (query, prepareAnswer(query, query.stringResult())) } catch {
                 case e: Throwable =>
    +              val logicalQueryInString = try {
    +                query.toString
    --- End diff --
    
    In what case does the `toString` throw an exception?  I think thats the real bug.  Is it because `Code Generation: ${executedPlan.codegenEnabled}` is not wrapped in `stringOrError`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org