spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tsingfu <...@git.apache.org>
Subject [GitHub] spark pull request: [SparkSQL][SPARK-4528] add comment support for...
Date Wed, 26 Nov 2014 10:12:05 GMT
GitHub user tsingfu opened a pull request:

    https://github.com/apache/spark/pull/3477

    [SparkSQL][SPARK-4528] add comment support for Spark SQL CLI  spark-sql

    while using *spark-sql*, found it does not support comment while write sqls. 
    **Comment support** is widely using in many projects, it is a necessary to add this feature.
    this implitation can be archived in  the source org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver.scala.
    ##### three comment styles supported:
    1. From a '#' character to the end of the line.
    2. From a '--' sequence to the end of the line
    3. From a /* sequence to the following */ sequence, as in the C programming language.
       This syntax allows a comment to extend over multiple lines because the beginning and
closing sequences need not be on the same line.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tsingfu/spark SPARK-4528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3477
    
----
commit 390aaf2b348bdc70bcfd1fa2a64c8b481deafa6f
Author: tsingfu <yangfuqing@gmail.com>
Date:   2014-11-26T10:01:24Z

    [SparkSQL][SPARK-4528] add comment support for Spark SQL CLI  spark-sql

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message