spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-3996: Shade Jetty in Spark deliverables.
Date Thu, 06 Nov 2014 07:05:13 GMT
GitHub user pwendell opened a pull request:

    https://github.com/apache/spark/pull/3130

    SPARK-3996: Shade Jetty in Spark deliverables.

    This patch relocates Jetty classes inside of the assembly jar in Spark.
    It does not modify Spark's disclosed dependency on Jetty, since we
    already ask users to mark Spark and its dependencies as "provided"
    anyways. This is a small fix that hopefully can be used as a template
    for other locations in which we shade libraries.
    
    This is a simpler version of #2984. If merged, this closes #2984.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pwendell/spark shading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3130
    
----
commit 931f409c0f94e8c290d94e507e778337164a6a38
Author: Patrick Wendell <pwendell@gmail.com>
Date:   2014-11-06T07:03:06Z

    SPARK-3996: Shade Jetty in Spark deliverables.
    
    This patch relocates Jetty classes inside of the assembly jar in Spark.
    It does not modify Spark's disclosed dependency on Jetty, since we
    already ask users to mark Spark and its dependencies as "provided"
    anyways. This is a small fix that hopefully can be used as a template
    for other locations in which we shade libraries.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message