spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4623]Add the some error infomation if u...
Date Sun, 30 Nov 2014 01:17:55 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3479#discussion_r21057521
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -389,6 +391,13 @@ object SparkSubmit {
       }
     
       /**
    +   * Return whether the given main class represents a sql shell.
    +   */
    +  private[spark] def isSqlShell(mainClass: String): Boolean = {
    +    mainClass == "org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver"
    --- End diff --
    
    Can you add comment int he SparkSQLCLIDriver class that explains there is a dependency
here on the exact name? Otherwise that class could be renamed and this would break inadvertently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message