spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...
Date Tue, 25 Nov 2014 05:40:27 GMT
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/3425#issuecomment-64312914
  
    @lvsoft I agreed that 127.0.0.1 is better than localhost in some cases, if it will not
work in the case of the machines only have IPv6, which happens in Facebook.
    
    In the first beginning, I did something as you have done, but after some digging, it seems
that there are many occurs of `localhost` in the codebase, then think about that maybe fix
`localhost` (make it resolvable) is better to replace it as `127.0.0.1`, there are many software
depend on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message