spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4518][SPARK-4519][Streaming] Refactored...
Date Thu, 20 Nov 2014 23:02:04 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/3389#issuecomment-63896387
  
    Overall this looks good - I might want to take one more pass to just make sure there are
no corner cases I can think of. But all of the comments were around naming, etc and not related
to correctness.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message