spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4486][MLLIB] Improve GradientBoosting A...
Date Thu, 20 Nov 2014 05:57:01 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3374#discussion_r20628796
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala
---
    @@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
      *    but weak hypothesis weights are not computed correctly for LogLoss or AbsoluteError.
    --- End diff --
    
    @manishamde The current explanation is correct for the original Gradient Boosting algorithm,
which uses weak hypothesis weights and is oblivious to the weak learner being used.  Your
suggested explanation is really for TreeBoost, Friedman's improvement to the original algorithm
which is specialized for trees (which we should add at some point but isn't what we're claiming
to have now, I'd say).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message