spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4429][BUILD] Build for Scala 2.11 using...
Date Wed, 19 Nov 2014 07:34:24 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3342#discussion_r20561042
  
    --- Diff: project/SparkBuild.scala ---
    @@ -101,14 +101,10 @@ object SparkBuild extends PomBuild {
           v.split("(\\s+|,)").filterNot(_.isEmpty).map(_.trim.replaceAll("-P", "")).toSeq
         }
     
    -    if (profiles.exists(_.contains("scala-"))) {
    -      profiles
    -    } else if (System.getProperty("scala-2.11") != null) {
    -      profiles ++ Seq("scala-2.11")
    -    } else {
    -      println("Enabled default scala profile")
    -      profiles ++ Seq("scala-2.10")
    +    if (System.getProperty("scala-2.11") == "") {
    +      System.setProperty("scala-2.11", "true")
    --- End diff --
    
    Could you add a comment here and link to the maven code this is replicating? It might
be tricky for other developers to understand why this exists.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message