spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4017] show progress bar in console
Date Mon, 17 Nov 2014 22:20:02 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3029#discussion_r20469995
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/ConsoleProgressBar.scala ---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ui
    +
    +import java.util.{Timer, TimerTask}
    +
    +import org.apache.spark._
    +
    +/**
    + * ConsoleProgressBar shows the progress of stages in the next line of the console. It
poll the
    + * status of active stages from `sc.statusTracker` in every 200ms, the progress bar will
be showed
    + * up after the stage has ran at least 500ms. If multiple stages run in the same time,
the status
    + * of them will be combined together, showed in one line.
    + */
    +private[spark] class ConsoleProgressBar(sc: SparkContext) extends Logging {
    +
    +  // Update period of progress bar, in milli seconds
    +  val UPDATE_PERIOD = 200L
    +  // Delay to show up a progress bar, in milli seconds
    +  val DELAY_SHOW_UP = 500L
    +
    +  // The width of terminal
    +  val TerminalWidth = if (!sys.env.getOrElse("COLUMNS", "").isEmpty) {
    --- End diff --
    
    It's possible that the COLUMNS could be "", so sys.env.contains() will not work


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message