spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [REVERT][SPARK-4213][SQL] ParquetFilters - No ...
Date Mon, 17 Nov 2014 05:11:16 GMT
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/3161#issuecomment-63260608
  
    I see, thanks for the explanation. Then I'd suggest to fix the 
    incomplete pattern matching problem first. Are you already working on 
    this? Otherwise I can open a PR for this.
    
    On 11/17/14 7:41 AM, Kousuke Saruta wrote:
    >
    > @liancheng <https://github.com/liancheng> One of the problems is the 
    > match error as you mentioned. And another one of the problem is that 
    > Parquet filter2 API's restriction. filter2.ValidTypeMap restricts 
    > which type we can use for filter operand.
    > https://github.com/Parquet/parquet-mr/blob/master/parquet-column/src/main/java/parquet/filter2/predicate/ValidTypeMap.java#L48
    > Because of the reason, when I wrote tests, I noticed Decimal, 
    > WrappedDate, WrappedTimestamp cannot be used.
    >
    > —
    > Reply to this email directly or view it on GitHub 
    > <https://github.com/apache/spark/pull/3161#issuecomment-63245652>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message