spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4180] [Core] Prevent creation of multip...
Date Sun, 16 Nov 2014 22:05:58 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3121#discussion_r20413659
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
    @@ -21,9 +21,62 @@ import org.scalatest.FunSuite
     
     import org.apache.hadoop.io.BytesWritable
     
    -class SparkContextSuite extends FunSuite {
    -  //Regression test for SPARK-3121
    +class SparkContextSuite extends FunSuite with LocalSparkContext {
    +
    +  /** Allows system properties to be changed in tests */
    +  private def withSystemProperty[T](property: String, value: String)(block: => T):
T = {
    --- End diff --
    
    should this be put in some test utility somewhere? Or at least we can make a JIRA to use
this throughout tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message