spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2321] Several progress API improvements...
Date Sat, 15 Nov 2014 05:28:45 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3197#discussion_r20400301
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkStatusAPI.scala ---
    @@ -140,3 +103,10 @@ private[spark] trait SparkStatusAPI { this: SparkContext =>
         }
       }
     }
    +
    +private[spark] object SparkStatusAPI {
    --- End diff --
    
    Sure, that's fine; I'll just make both constructors `private[spark]` and add a note; as
long as we've warned users not to call the constructor and hidden it from the Scaladoc, then
I don't think anyone should complain if we need to change it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message