spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2624 add datanucleus jars to the contain...
Date Fri, 14 Nov 2014 05:39:20 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3238#discussion_r20343870
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -223,6 +224,29 @@ private[spark] trait ClientBase extends Logging {
             }
           }
         }
    +
    +    /**
    +     * Do the same for datanucleus jars, if they exist in spark home. Find all datanucleus-*
jars,
    +     * copy them to the remote fs, and add them to the class path.
    +     */
    +    val sparkHomeOpt = sparkConf.getOption("spark.home").orElse(sys.env.get("SPARK_HOME"))
    +    for (sparkHome <- sparkHomeOpt) {
    +      val libs = sparkHome + Path.SEPARATOR + "lib"
    +      val jars = new File(libs).listFiles(new FilenameFilter() {
    +        override def accept(dir: File, name: String) = name.startsWith("datanucleus-")
    +      })
    +      // copy to remote and add to classpath
    +      jars.foreach { jar =>
    --- End diff --
    
    Isn't it because of licensing? Datanucleus is  
    LGPL or similar?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message