spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4214. With dynamic allocation, avoid out...
Date Tue, 11 Nov 2014 19:08:55 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3204#discussion_r20172344
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -110,6 +110,12 @@ private[spark] class ExecutorAllocationManager(sc: SparkContext)
extends Logging
       // Clock used to schedule when executors should be added and removed
       private var clock: Clock = new RealClock
     
    +  // TODO: The default value of 1 for spark.executor.cores works right now because dynamic
    +  // allocation is only supported for YARN and the default number of cores per executor
in YARN is
    +  // 1, but it might need to be attained differently for different cluster managers
    +  private val tasksPerExecutor =
    +    conf.getInt("spark.executor.cores", 1) / conf.getInt("spark.task.cpus", 1)
    --- End diff --
    
    This would be a misconfiguration because executors wouldn't be able to fit a single task.
 Will add an exception to make it fail earlier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message