spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...
Date Mon, 10 Nov 2014 13:57:03 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3158#discussion_r20082396
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SpecificMutableRow.scala
---
    @@ -169,6 +170,35 @@ final class MutableByte extends MutableValue {
         newCopy.asInstanceOf[this.type]
       }
     }
    +final class MutableDate extends MutableValue {
    --- End diff --
    
    Yea, just to be clear, you may notice that all those `MutableXxx` classes are for primitive
types. They are used to avoid boxing costs. On the other hand, `Date` and `Timestamp` objects
are always boxed anyway. That's why they are unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message