spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <>
Subject [GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...
Date Fri, 07 Nov 2014 20:20:31 GMT
Github user marmbrus commented on a diff in the pull request:
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
    @@ -341,12 +341,21 @@ abstract class HiveComparisonTest
               val query = new TestHive.HiveQLQueryExecution(queryString)
               try { (query, prepareAnswer(query, query.stringResult())) } catch {
                 case e: Throwable =>
    +              val logicalQueryInString = try {
    +                query.toString
    --- End diff --
    In what case does the `toString` throw an exception?  I think thats the real bug.  Is
it because `Code Generation: ${executedPlan.codegenEnabled}` is not wrapped in `stringOrError`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message