Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3142#issuecomment-62104110
Hey Aaron - this LGTM and seems pretty straightforward. Just wondering, what is the behavior
if it can't bind to that port? I'm thinking about the case where multiple workers are running
on each machine. Will it crash the worker or just e.g. send a log message? If the latter,
I think this would still work correctly... it would be a bit hackish, but one worker would
grab the port first and then the others would not start a shuffle service.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
|