spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3891][SQL] Add array support to percent...
Date Wed, 05 Nov 2014 06:29:36 GMT
Github user gvramana commented on the pull request:

    https://github.com/apache/spark/pull/2802#issuecomment-61765420
  
    Fixed all the comments.
    1. testcase reset problem, can be tracked as separate bug.
    2. i think space following ',' can also be added to scala style check atleast to give
warning, if not error.
    3. testsuites can also be covered under style check.
    
    Please let me know if any other comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message