spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4183] Close transport-related resources...
Date Sun, 02 Nov 2014 08:04:35 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3053#discussion_r19710333
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -491,17 +491,16 @@ class StreamingContext private[streaming] (
         // or context is stopped before starting
         if (state == Initialized) {
           logWarning("StreamingContext has not been started yet")
    -      return
    -    }
    -    if (state == Stopped) {
    +    } else if (state == Stopped) {
    --- End diff --
    
    @tdas Please take a look at this change and StreamingContextSuite. The issue here is that
we would not stop the spark context if we didn't start the SSC, even though the SparkContext
has already been created.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message