spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aarondav <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4163][Core][WebUI] Send the fetch failu...
Date Sat, 01 Nov 2014 07:46:46 GMT
Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3032#discussion_r19702216
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1060,7 +1060,7 @@ class DAGScheduler(
             if (runningStages.contains(failedStage)) {
               logInfo(s"Marking $failedStage (${failedStage.name}) as failed " +
                 s"due to a fetch failure from $mapStage (${mapStage.name})")
    -          markStageAsFinished(failedStage, Some("Fetch failure"))
    +          markStageAsFinished(failedStage, Some(failureMessage))
    --- End diff --
    
    Looking at some of the other error messages that are displayed in the UI's stages view,
I think it's safer to add more information -- let's just prepend something like "Fetch failure:"
to the exception, because the exception itself may sound totally unrelated (some timeout,
file not found, etc.) and it's unclear why the whole stage was finished.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message