Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C370174E8 for ; Wed, 29 Oct 2014 17:58:48 +0000 (UTC) Received: (qmail 98643 invoked by uid 500); 29 Oct 2014 17:58:48 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 98619 invoked by uid 500); 29 Oct 2014 17:58:48 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 98605 invoked by uid 99); 29 Oct 2014 17:58:47 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Oct 2014 17:58:47 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id A6652884750; Wed, 29 Oct 2014 17:58:47 +0000 (UTC) From: vanzin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-3795] Heuristics for dynamically scalin... Content-Type: text/plain Message-Id: <20141029175847.A6652884750@tyr.zones.apache.org> Date: Wed, 29 Oct 2014 17:58:47 +0000 (UTC) Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-60972887 LGTM, although I'll probably go through it again later (but don't wait for that). I think we should file a sub-task to look at static vs. dynamic allocation user options and make sure we do something sane. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org