Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EEF217678 for ; Mon, 27 Oct 2014 16:52:15 +0000 (UTC) Received: (qmail 75337 invoked by uid 500); 27 Oct 2014 16:52:15 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 75329 invoked by uid 500); 27 Oct 2014 16:52:15 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 75318 invoked by uid 99); 27 Oct 2014 16:52:14 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2014 16:52:14 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 547F690A2E4; Mon, 27 Oct 2014 16:52:14 +0000 (UTC) From: vanzin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [WIP][SPARK-1720][SPARK-1719] use LD_LIBRARY_P... Content-Type: text/plain Message-Id: <20141027165214.547F690A2E4@tyr.zones.apache.org> Date: Mon, 27 Oct 2014 16:52:14 +0000 (UTC) Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2711#issuecomment-60626712 On the Unix side I think the changes are ok, but I don't know how Yarn works on Windows as far as launching containers, nor do I have any Windows box where to find that out... so it would be nice to at least test it's doing the right thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org