spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL] Fixes the race condition that may cause ...
Date Thu, 16 Oct 2014 10:18:56 GMT
GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/2823

    [SQL] Fixes the race condition that may cause test failure

    The removed `Future` was used to end the test case as soon as the Spark SQL CLI process
exits. When the process exits prematurely, this mechanism prevents the test case to wait until
timeout. But it also creates a race condition: when `foundAllExpectedAnswers.tryFailure` is
called, there are chances that the last expected output line of the CLI process hasn't been
caught by the main logics of the test code, thus fails the test case.
    
    Removing this `Future` doesn't affect correctness.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark clean-clisuite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2823
    
----
commit 489a97c3ab0fb034d4a9bff2ce3cb994756021e8
Author: Cheng Lian <lian.cs.zju@gmail.com>
Date:   2014-10-16T09:00:39Z

    Fixes the race condition that may cause test failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message