spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3873] [build] Add style checker to enfo...
Date Fri, 10 Oct 2014 23:04:20 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/2757

     [SPARK-3873] [build] Add style checker to enforce import ordering. 

    The checker tries to follow as closely as possible the guidelines of
    the code style document, and makes some decisions where the guide is
    not clear. In particular:
    
    - wildcard imports come first when there are other imports in the
      same package
    - multi-import blocks come before single imports
    - lower-case names inside multi-import blocks come before others
    
    In some projects, such as graphx, there seems to be a convention to
    separate o.a.s imports from the project's own; to simplify the
    checker, I chose not to allow that, which is a strict interpretation
    of the code style guide, even though I think it makes sense.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-3873

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2757
    
----
commit 3c9c3cab4de250838e2092bb6219ec52801514a8
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2014-10-10T22:01:29Z

    [SPARK-3873] [build] Add style checker to enforce import ordering.
    
    The checker tries to follow as closely as possible the guidelines of
    the code style document, and makes some decisions where the guide is
    not clear. In particular:
    
    - wildcard imports come first when there are other imports in the
      same package
    - multi-import blocks come before single imports
    - lower-case names inside multi-import blocks come before others
    
    In some projects, such as graphx, there seems to be a convention to
    separate o.a.s imports from the project's own; to simplify the
    checker, I chose not to allow that, which is a strict interpretation
    of the code style guide, even though I think it makes sense.

commit b6a14a833d1fe39b41528ad68bea9df12b1136cc
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2014-10-10T22:04:32Z

    Fix all imports that fail the new style checker.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message