spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3936] Remove Bytecode Inspection for Jo...
Date Fri, 31 Oct 2014 22:49:40 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2815#discussion_r19697859
  
    --- Diff: graphx/src/main/scala/org/apache/spark/graphx/Graph.scala ---
    @@ -207,8 +213,9 @@ abstract class Graph[VD: ClassTag, ED: ClassTag] protected () extends
Serializab
        * }}}
        *
        */
    -  def mapTriplets[ED2: ClassTag](map: EdgeTriplet[VD, ED] => ED2): Graph[VD, ED2]
= {
    -    mapTriplets((pid, iter) => iter.map(map))
    +  def mapTriplets[ED2: ClassTag](map: EdgeTriplet[VD, ED] => ED2,
    --- End diff --
    
    i'd deprecate the old one and create a new one for the new api.
    
    the old one should keep the old behavior


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message