spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3796] Create external service which can...
Date Fri, 31 Oct 2014 02:06:32 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3001#discussion_r19648280
  
    --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/StandaloneShuffleBlockManager.java
---
    @@ -0,0 +1,151 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network.shuffle;
    +
    +import java.io.DataInputStream;
    +import java.io.File;
    +import java.io.FileInputStream;
    +import java.io.IOException;
    +import java.util.concurrent.ConcurrentHashMap;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.spark.network.buffer.FileSegmentManagedBuffer;
    +import org.apache.spark.network.buffer.ManagedBuffer;
    +import org.apache.spark.network.util.JavaUtils;
    +
    +/**
    + * Manages converting shuffle BlockIds into physical segments of local files. Each Executor
must
    + * register its own configuration about where it stores its files (local dirs) and how
(shuffle
    + * manager). The logic for retrieval of individual files is replicated from Spark's
    + * FileShuffleBlockManager and IndexShuffleBlockManager.
    + *
    + * Executors with shuffle file consolidation are not currently supported, as the index
is stored in
    + * the Executor's memory, unlike the IndexShuffleBlockManager.
    + */
    +public class StandaloneShuffleBlockManager {
    --- End diff --
    
    Oh cool. I think we should call it something else because a lot of people automatically
associate "standalone" with the cluster manager. There was a PR a while back that rewords
this in the docs to replace "standalone" with something like "self-contained" or "isolated"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message