spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3247][SQL] An API for adding data sourc...
Date Fri, 31 Oct 2014 02:04:19 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2475#discussion_r19648230
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
    @@ -389,7 +389,7 @@ case class ArrayType(elementType: DataType, containsNull: Boolean)
extends DataT
      * @param dataType The data type of this field.
      * @param nullable Indicates if values of this field can be `null` values.
      */
    -case class StructField(name: String, dataType: DataType, nullable: Boolean) {
    +case class StructField(name: String, dataType: DataType, nullable: Boolean = true) {
    --- End diff --
    
    We don't _need_ to, but `nullablility` is purely an optimization (that we don't even take
advantage of for the most part).  Other parts of the API already default nullable to true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message