spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4109][CORE] Correctly deserialize Task....
Date Wed, 29 Oct 2014 06:13:12 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2971#discussion_r19521513
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala ---
    @@ -128,7 +128,7 @@ private[spark] class ShuffleMapTask(
       }
     
       override def readExternal(in: ObjectInput) {
    --- End diff --
    
    As long as you're modifying this code, mind tossing a `Utils.tryOrIOException` here so
that any errors that occur here are reported properly?  See #2932 for explanation / context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message