spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <>
Subject [GitHub] spark pull request: [SPARK-4028][Streaming] ReceivedBlockHandler i...
Date Tue, 28 Oct 2014 23:02:58 GMT
Github user tdas commented on a diff in the pull request:
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceiverSupervisorImpl.scala
    @@ -44,12 +41,26 @@ import org.apache.spark.streaming.scheduler.RegisterReceiver
     private[streaming] class ReceiverSupervisorImpl(
         receiver: Receiver[_],
    -    env: SparkEnv
    +    env: SparkEnv,
    +    hadoopConf: Configuration,
    +    checkpointDirOption: Option[String]
    --- End diff --
    See my comment on that thread, on my preference to have Option in the name. Also spoke
to @pwendell offline, and he does not seem to have a strong opinion on this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message