spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4016] Allow user to show/hide UI metric...
Date Tue, 28 Oct 2014 18:52:58 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2867#discussion_r19494574
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -65,55 +65,100 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIPage("stage")
{
                   <strong>Total task time across all tasks: </strong>
                   {UIUtils.formatDuration(stageData.executorRunTime)}
                 </li>
    -            {if (hasInput)
    +            {if (hasInput) {
                   <li>
                     <strong>Input: </strong>
                     {Utils.bytesToString(stageData.inputBytes)}
                   </li>
    -            }
    -            {if (hasShuffleRead)
    +            }}
    +            {if (hasShuffleRead) {
                   <li>
                     <strong>Shuffle read: </strong>
                     {Utils.bytesToString(stageData.shuffleReadBytes)}
                   </li>
    -            }
    -            {if (hasShuffleWrite)
    +            }}
    +            {if (hasShuffleWrite) {
                   <li>
                     <strong>Shuffle write: </strong>
                     {Utils.bytesToString(stageData.shuffleWriteBytes)}
                   </li>
    -            }
    -            {if (hasBytesSpilled)
    -            <li>
    -              <strong>Shuffle spill (memory): </strong>
    -              {Utils.bytesToString(stageData.memoryBytesSpilled)}
    -            </li>
    -            <li>
    -              <strong>Shuffle spill (disk): </strong>
    -              {Utils.bytesToString(stageData.diskBytesSpilled)}
    -            </li>
    -            }
    +            }}
    +            {if (hasBytesSpilled) {
    +              <li>
    +                <strong>Shuffle spill (memory): </strong>
    +                {Utils.bytesToString(stageData.memoryBytesSpilled)}
    +              </li>
    +              <li>
    +                <strong>Shuffle spill (disk): </strong>
    +                {Utils.bytesToString(stageData.diskBytesSpilled)}
    +              </li>
    +            }}
               </ul>
             </div>
    -        // scalastyle:on
    +
    +      val showAdditionalMetrics =
    +        <div>
    +          <span class="expand-additional-metrics-arrow arrow-closed"></span>
    +          <span class="expand-additional-metrics"><strong>Show additional
metrics</strong></span>
    +          <div class="additional-metrics collapsed">
    +            <ul style="list-style-type:none">
    +              <li>
    +                <span data-toggle="tooltip"
    +                      title={ToolTips.SCHEDULER_DELAY} data-placement="right">
    +                  <input type="checkbox" name={TaskDetailsClassNames.SCHEDULER_DELAY}/>
    +                  Scheduler Delay
    +                </span>
    +              </li>
    +              <li>
    +                <span data-toggle="tooltip"
    +                      title={ToolTips.GC_TIME} data-placement="right">
    +                  <input type="checkbox" name={TaskDetailsClassNames.GC_TIME}/>
    +                  GC Time
    +                </span>
    +              </li>
    +              <li>
    +                <span data-toggle="tooltip"
    +                      title={ToolTips.RESULT_SERIALIZATION_TIME} data-placement="right">
    +                  <input type="checkbox" name={TaskDetailsClassNames.RESULT_SERIALIZATION_TIME}/>
    +                  Result Serialization Time
    +                </span>
    +              </li>
    +              <li>
    +                <span data-toggle="tooltip"
    +                      title={ToolTips.GETTING_RESULT_TIME} data-placement="right">
    +                  <input type="checkbox" name={TaskDetailsClassNames.GETTING_RESULT_TIME}/>
    +                  Getting Result Time
    +                </span>
    +              </li>
    +            </ul>
    +          </div>
    +        </div>
    +
           val accumulableHeaders: Seq[String] = Seq("Accumulable", "Value")
           def accumulableRow(acc: AccumulableInfo) = <tr><td>{acc.name}</td><td>{acc.value}</td></tr>
           val accumulableTable = UIUtils.listingTable(accumulableHeaders, accumulableRow,
             accumulables.values.toSeq)
     
    -      val taskHeaders: Seq[String] =
    +      val taskHeadersAndClasses: Seq[(String, String)] =
    --- End diff --
    
    Can you add a // comment here to explain what "classes" means?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message