spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-1720][SPARK-1719] use LD_LIBRARY_P...
Date Tue, 28 Oct 2014 18:06:14 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2711#discussion_r19491063
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
    @@ -38,6 +40,31 @@ object CommandUtils extends Logging {
           command.arguments
       }
     
    +  def buildLocalCommand(
    --- End diff --
    
    Can you add a java doc, something like
    ```
    /**
     * Build a command based on the given one, taking into account the local environment of
where
     * this command is expected to run, substitute any placeholders, and append any extra
class paths.
     * The `env` argument is exposed for testing.
     */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message