spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3453] Netty-based BlockTransferService,...
Date Mon, 27 Oct 2014 21:26:18 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2753#discussion_r19438500
  
    --- Diff: network/common/src/main/java/org/apache/spark/network/client/ChunkFetchFailureException.java
---
    @@ -15,18 +15,23 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.network.netty.server
    +package org.apache.spark.network.client;
     
     /**
    - * Header describing a block. This is used only in the server pipeline.
    - *
    - * [[BlockServerHandler]] creates this, and [[BlockHeaderEncoder]] encodes it.
    - *
    - * @param blockSize length of the block content, excluding the length itself.
    - *                 If positive, this is the header for a block (not part of the header).
    - *                 If negative, this is the header and content for an error message.
    - * @param blockId block id
    - * @param error some error message from reading the block
    + * General exception caused by a remote exception while fetching a chunk.
      */
    -private[server]
    -class BlockHeader(val blockSize: Int, val blockId: String, val error: Option[String]
= None)
    +public class ChunkFetchFailureException extends RuntimeException {
    --- End diff --
    
    we should probably pass the chunkIndex into the exception message, either override getMessage,
or just put it as part of the message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message