spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ScrapCodes <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3997][Build]scalastyle should output th...
Date Sat, 25 Oct 2014 07:07:03 GMT
Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2846#discussion_r19374351
  
    --- Diff: project/SparkBuild.scala ---
    @@ -111,7 +110,7 @@ object SparkBuild extends PomBuild {
       lazy val MavenCompile = config("m2r") extend(Compile)
       lazy val publishLocalBoth = TaskKey[Unit]("publish-local", "publish local for m2 and
ivy")
     
    -  lazy val sharedSettings = graphSettings ++ ScalaStyleSettings ++ genjavadocSettings
++ Seq (
    +  lazy val sharedSettings = graphSettings ++ genjavadocSettings ++ Seq (
    --- End diff --
    
    Why scala style settings is removed ? is it no longer needed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message