spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-3770: Make userFeatures accessible from ...
Date Tue, 21 Oct 2014 07:35:12 GMT
Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/2636#issuecomment-59889793
  
    @mdagost Thanks for working on the SerDe! I tested it locally and it works correctly,
but the unit tests for the added methods are missing. Do you mind adding them? You can follow
    
    https://github.com/mdagost/spark/blob/mf_user_features/python/pyspark/mllib/recommendation.py#L55
    
    Basically, we want to verify that userFeatures/productFeatures returns an RDD of key-value
pairs with the correct number of records and for each records the feature dimension is correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message