spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3958] TorrentBroadcast cleanup / debugg...
Date Mon, 20 Oct 2014 22:33:08 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2844#discussion_r19118825
  
    --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
    @@ -227,6 +217,7 @@ private object TorrentBroadcast extends Logging {
        * If removeFromDriver is true, also remove these persisted blocks on the driver.
        */
       def unpersist(id: Long, removeFromDriver: Boolean, blocking: Boolean) = {
    +    logInfo(s"Unpersisting TorrentBroadcast $id")
    --- End diff --
    
    this can be chatty. logdebug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message