spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3941][CORE] _remainingmem should not in...
Date Fri, 17 Oct 2014 01:15:49 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2792#discussion_r18997247
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
    @@ -457,16 +457,18 @@ private[spark] class BlockManagerInfo(
     
         if (_blocks.containsKey(blockId)) {
           // The block exists on the slave already.
    -      val originalLevel: StorageLevel = _blocks.get(blockId).storageLevel
    +      val blockStatus: BlockStatus = _blocks.get(blockId)
    +      val originalLevel: StorageLevel = blockStatus.storageLevel
    +      val originalMemSize: Long = blockStatus.memSize
     
           if (originalLevel.useMemory) {
    -        _remainingMem += memSize
    +        _remainingMem += originalMemSize
    --- End diff --
    
    This seems like a change in semantics. Can you explain why the old code is incorrect?
I'm just trying to understand what this block is trying to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message