spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2321] [WIP] Stable pull-based progress ...
Date Wed, 15 Oct 2014 00:16:12 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2696#discussion_r18868548
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -229,10 +233,26 @@ class SparkContext(config: SparkConf) extends Logging {
       private[spark] val metadataCleaner =
         new MetadataCleaner(MetadataCleanerType.SPARK_CONTEXT, this.cleanup, conf)
     
    -  // Initialize the Spark UI, registering all associated listeners
    +
    +  private[spark] val environmentListener = new EnvironmentListener
    --- End diff --
    
    If that's your goal, then I'd suggest refactoring these listeners. The only one I see
being used outside of the UI is the job progress one. So all the others could still be kept
internal to the UI.
    
    It just feels really weird to be importing a bunch of UI-specific classes to service functionality
that is not UI-specific.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message