spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2321] [WIP] Stable pull-based progress ...
Date Tue, 14 Oct 2014 20:38:19 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/2696#issuecomment-59112305
  
    Hi @JoshRosen,
    
    I think this is going in the right direction and is definitely an improvement over the
status quo. I left some comments about semantics of certain parts of the API and some general
suggestions.
    
    One thing is that this PR seems to cover half of SPARK-2321 - the part about monitoring,
but not the listener API. Perhaps that bug should be broken into separate sub-tasks?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message