spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2321] [WIP] Stable pull-based progress ...
Date Tue, 14 Oct 2014 20:25:15 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2696#discussion_r18855753
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -853,6 +873,12 @@ class SparkContext(config: SparkConf) extends Logging {
       /** The version of Spark on which this application is running. */
       def version = SPARK_VERSION
     
    +  def getJobsIdsForGroup(jobGroup: String): Array[Int] = statusApi.jobIdsForGroup(jobGroup)
    --- End diff --
    
    Probably a good idea to add scaladoc to all these new public methods.
    
    In this case in particular, should probably mention that the returned list is a view of
the current state, and subsequent invocations may return a different list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message