spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-3874, Provide stable TaskContext API
Date Tue, 14 Oct 2014 18:07:01 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2782#discussion_r18846854
  
    --- Diff: core/src/main/java/org/apache/spark/TaskContext.java ---
    @@ -116,33 +55,19 @@ public static TaskContext get() {
       }
     
       /** :: Internal API ::  */
    -  public static void unset() {
    +  static void unset() {
         taskContext.remove();
       }
     
    -  // List of callback functions to execute when the task completes.
    -  private transient List<TaskCompletionListener> onCompleteCallbacks =
    -    new ArrayList<TaskCompletionListener>();
    -
    -  // Whether the corresponding task has been killed.
    -  private volatile boolean interrupted = false;
    -
    -  // Whether the task has completed.
    -  private volatile boolean completed = false;
    -
       /**
        * Checks whether the task has completed.
        */
    -  public boolean isCompleted() {
    -    return completed;
    -  }
    +  public abstract boolean isCompleted();
    --- End diff --
    
    My understanding is that isCompleted means it has been completed, whereas isComplete means
it is "whole".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message