spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2621. Update task InputMetrics increment...
Date Mon, 13 Oct 2014 21:18:48 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2087#discussion_r18795643
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
    @@ -147,12 +150,36 @@ class NewHadoopRDD[K, V](
               throw new java.util.NoSuchElementException("End of stream")
             }
             havePair = false
    +
    +        // Update bytes read metric every 32 records
    --- End diff --
    
    It would be better to pull this number into a constant and also probably make it much
higher... 32 will have a performance implication since there is e.g. thread locals and other
stuff going on here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message