spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP][SPARK-1720][SPARK-1719] use LD_LIBRARY_P...
Date Thu, 09 Oct 2014 18:27:46 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2711#discussion_r18664237
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnableUtil.scala
---
    @@ -58,6 +61,10 @@ trait ExecutorRunnableUtil extends Logging {
         sys.env.get("SPARK_JAVA_OPTS").foreach { opts =>
           javaOpts += opts
         }
    +    sys.props.get("spark.executor.extraLibraryPath").foreach { p =>
    +      val libraryPath = Seq(p, Utils.libraryPathScriptVar).mkString(File.pathSeparator)
    --- End diff --
    
    I see this logic to buld `LD_LIBRARY_PATH=foo` in at least 3 different places, and they
all look very similar if not identical. Probably time to put this in a helper method somewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message