spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3781] code format and little improvemen...
Date Thu, 09 Oct 2014 16:30:41 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2734#discussion_r18656785
  
    --- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
    @@ -34,16 +34,15 @@ case class Aggregator[K, V, C] (
         mergeValue: (C, V) => C,
         mergeCombiners: (C, C) => C) {
     
    -  private val externalSorting = SparkEnv.get.conf.getBoolean("spark.shuffle.spill", true)
    +  private val externalSorting = SparkEnv.get.conf.getBoolean("spark.shuffle.spill", defaultValue
= true)
    --- End diff --
    
    Why add the parameter name here? it's obviously the default value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message