spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwf <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2750] support https in spark web ui
Date Thu, 09 Oct 2014 12:30:30 GMT
Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1980#discussion_r18641539
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -205,10 +231,74 @@ private[spark] object JettyUtils extends Logging {
         ServerInfo(server, boundPort, collection)
       }
     
    +  // to generate a new url string scheme://server:port+path
    --- End diff --
    
    Hi @vanzin, actually here i just refer to the code of jetty 9 see(https://github.com/eclipse/jetty.project/blob/master/jetty-util/src/main/java/org/eclipse/jetty/util/URIUtil.java#L726-L733)
 since there is no ```newURI```method in spark jetty version(spark use jetty 8).
    
    And  L238 is for the case to handle IPv6 address, here we can remove it if unnecessary.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message