spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ScrapCodes <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3677] [BUILD] [YARN] pom.xml and SparkB...
Date Wed, 08 Oct 2014 10:42:16 GMT
Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2520#discussion_r18574479
  
    --- Diff: project/SparkBuild.scala ---
    @@ -170,6 +178,24 @@ object SparkBuild extends PomBuild {
     
     }
     
    +object YARNCommon {
    +  lazy val settings = Seq(
    +    scalaSource in Compile := baseDirectory.value / "common/src/main/scala"
    +  )
    +}
    +
    +object YARNAlpha {
    +  lazy val settings = Seq(
    +    unmanagedSourceDirectories in Compile += baseDirectory.value / "alpha/src/main/scala"
    --- End diff --
    
    This setting line is about "yarn-alpha" and not common ? 
    
    So changes related to common is acceptable. But you can safely delete this setting. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message