spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From derrickburns <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...
Date Mon, 06 Oct 2014 21:53:20 GMT
Github user derrickburns commented on the pull request:

    https://github.com/apache/spark/pull/2634#issuecomment-58106085
  
    I know exactly which closure is exceeding the size limitation. The problem,
    is that I cannot see how to make the closure capture less data!
    
    On Mon, Oct 6, 2014 at 2:42 PM, Xiangrui Meng <notifications@github.com>
    wrote:
    
    > @derrickburns <https://github.com/derrickburns> The style test doesn't
    > capture all, unfortunately. The Spark Code Style Guide is the first place
    > to check. I will mark a few examples inline.
    >
    > I think the best way to trace down the problem is to split this PR into
    > small ones and see whether we can find it. Is there a good way to split
    > this? Thanks!
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/2634#issuecomment-58104576>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message