spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3752][SQL]: Add tests for different UDF...
Date Sun, 05 Oct 2014 03:10:34 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2621#discussion_r18433069
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUdfSuite.scala
---
    @@ -17,29 +17,32 @@
     
     package org.apache.spark.sql.hive.execution
     
    -import java.io.{DataOutput, DataInput}
    +import java.io.{DataInput, DataOutput}
     import java.util
     import java.util.Properties
     
    -import org.apache.spark.util.Utils
    -
    -import scala.collection.JavaConversions._
    -
     import org.apache.hadoop.conf.Configuration
    -import org.apache.hadoop.hive.serde2.{SerDeStats, AbstractSerDe}
    -import org.apache.hadoop.io.Writable
    -import org.apache.hadoop.hive.serde2.objectinspector.{ObjectInspectorFactory, ObjectInspector}
    -
    -import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory
     import org.apache.hadoop.hive.ql.udf.generic.GenericUDF
     import org.apache.hadoop.hive.ql.udf.generic.GenericUDF.DeferredObject
    -
    +import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory
    +import org.apache.hadoop.hive.serde2.objectinspector.{ObjectInspector, ObjectInspectorFactory}
    +import org.apache.hadoop.hive.serde2.{AbstractSerDe, SerDeStats}
    +import org.apache.hadoop.io.Writable
     import org.apache.spark.sql.Row
     import org.apache.spark.sql.hive.test.TestHive
     import org.apache.spark.sql.hive.test.TestHive._
    +import org.apache.spark.util.Utils
    +
    +import scala.collection.JavaConversions._
     
     case class Fields(f1: Int, f2: Int, f3: Int, f4: Int, f5: Int)
     
    +// Case classes for the custom UDF's.
    +case class IntegerCaseClass(i: Int)
    +case class ListListIntCaseClass(lli: Seq[Tuple3[Int, Int, Int]])
    --- End diff --
    
    Use the idomatic syntax for tuple types: `Seq[(Int, Int, Int)]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message