spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3627] - [yarn] - fix exit code and fina...
Date Fri, 03 Oct 2014 20:37:41 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2577#discussion_r18418213
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
    @@ -328,10 +349,18 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments,
       private def waitForSparkDriver(): ActorRef = {
         logInfo("Waiting for Spark driver to be reachable.")
         var driverUp = false
    +    var count = 0
         val hostport = args.userArgs(0)
         val (driverHost, driverPort) = Utils.parseHostPort(hostport)
    -    while (!driverUp) {
    +
    +    // spark driver should already be up since it launched us, but we don't want to
    +    // wait forever, so wait 100 seconds max to match the cluster mode setting.
    +    // Leave this config unpublished for now.
    --- End diff --
    
    minor, but can you add `SPARK-3779` to the comment so others know we're tracking this
issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message